S3 Storage - Fargate Credentials #2076
Conversation
There was a problem hiding this comment.
Thank you, @els-tmiller, good job!
I just left some minor comments.
Please also note that commits should have signed signatures, so it's a good idea to force push a single signed commit after you applied the changes.
|
@ostafen I believe this has your requested changes |
|
@els-tmiller: the pipeline are failing at building the code, can you please check? Please also note that commits should have verified signatures. |
Sorry, been fighting git to squash the old commits, I think i have it now. |
els-tmiller
force-pushed
the
fargate
branch
3 times, most recently
from
f1d91ab to
3285112
Compare
|
All tests are now passing in my fork and my git log shows the squashed commit being signed. |
ostafen
left a comment
ostafen
left a comment
There was a problem hiding this comment.
@els-tmiller: something happened with the merge, since this PR has also recent changes from master
Should be fixed. sorry for all the hassle |
|
@els-tmiller please sign your commit |
els-tmiller
force-pushed
the
fargate
branch
2 times, most recently
from
7738450 to
dd517c8
Compare
Finally says "verified" |
3 participants
This adds support for Fargate credentials. There is a unique metadata uri for ECS which Fargate can use to source credentials associated with the Task role. These can be used to authenticate with S3 Storage.